Refactor formatSelection callback
#615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| function getFormatRule(formatCommand: string): FormatRule | null { | ||
| // We reuse regexes from expensify-common with modified flags, and they don’t sync automatically. | ||
| // When expensify-common updates its regexes, we should manually maintain the regex and matchGroup properties here. |
There was a problem hiding this comment.
Maybe we should add some comments to expensify-common rules that will remind developers to do this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR refactors the
formatSelectioncallback to make it more generic and updates the web example to support format toggling.Currently, the interface is as follows:
Arguments:
selectedText,formatCommandReturns:
formattedTextAfter this change, the interface will be:
Arguments:
text,selectionStart,selectionEnd,formatCommandReturns:
updatedText,cursorOffsetRelated Issues
Expensify/App#55088
PROPOSAL: Expensify/App#55088 (comment)
Manual Tests
N/A
Linked PRs