-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repeated fetching in the API #176
Conversation
@grgia bump for review please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and I tested locally and only get ~25 network requests each minute. Also, there is no flashing while command clicking.
The only suggestion I'd make is documenting a guideline about when to use this pattern- i.e. should it wrap every API call?
OK, added! |
…ensify/k2-extension into tgolen-fix-repeated-fetching
Thanks! Submitted to the chrome store.
…On Wed, Dec 13, 2023 at 10:30 AM Georgia Monahan ***@***.***> wrote:
Merged #176 <#176> into
main.
—
Reply to this email directly, view it on GitHub
<#176 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJMAB3MZUBP3YQ5ZRGJ4TLYJHQ2NAVCNFSM6AAAAABAM5GKNKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGIZTQOBXGI3DANA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I was finding a few problems recently that I've been fixing.
This PR should fix both of those problems.
Tests