feat: add keyIdentifier.derive()
#99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparten11740
commented
May 7, 2024
Comment on lines
+7
to
+10
| const isDerivationPath = (derivationPath) => | ||
| typeof derivationPath === 'object' && | ||
| Symbol.toStringTag in derivationPath && | ||
| derivationPath[Symbol.toStringTag]() === 'DerivationPath' |
There was a problem hiding this comment.
to avoid instanceof - maybe worth porting to key-utils
mvayngrib
approved these changes
May 7, 2024
yes |
|
Just to make sure I will update this where it's most crucial (address provider) and see if it breaks any of the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
derivewhich accepts a partial derivation path and returns a newKeyIdentifierinstance that has a derivation path that is extended with the supplied path indices.Captured from https://github.com/ExodusMovement/exodus-hydra/pull/6497/files#r1575088966