Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for schnorr signatures #90

Merged
merged 9 commits into from
Apr 26, 2024
Merged

feat: support for schnorr signatures #90

merged 9 commits into from
Apr 26, 2024

Conversation

feri42
Copy link
Contributor

@feri42 feri42 commented Apr 19, 2024

Add support for schnorr signatures in secp256k1 signer

@feri42 feri42 self-assigned this Apr 19, 2024
@feri42 feri42 requested a review from fboucquez April 19, 2024 22:50
fboucquez
fboucquez previously approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@fboucquez fboucquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Nice!

it would be cool to integrate the new keychain with asests' bitcoin and run all the tests
Another alternative is to generate more fixtures from assets' tests

@feri42
Copy link
Contributor Author

feri42 commented Apr 22, 2024

it would be cool to integrate the new keychain with asests' bitcoin and run all the tests Another alternative is to generate more fixtures from assets' tests

There is a draft here: https://github.com/ExodusMovement/assets/pull/2059

kewde
kewde reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@kewde kewde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken a quick pass, maybe we can improve this a little bit still!

features/keychain/module/crypto/tweak.js Outdated Show resolved Hide resolved
features/keychain/module/crypto/tweak.js Outdated Show resolved Hide resolved
features/keychain/module/crypto/secp256k1.js Outdated Show resolved Hide resolved
kewde
kewde previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@kewde kewde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@feri42 feri42 force-pushed the f/support-for-schnorr branch 3 times, most recently from d6c95f0 to cb7d1e1 Compare April 24, 2024 12:26
kewde
kewde previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@kewde kewde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - nice!

fboucquez
fboucquez previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@fboucquez fboucquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

in addition to pass key, this new key chain would reduce the desktop signing process to bare bone right? Removing all of this wallet code

@feri42 feri42 dismissed stale reviews from fboucquez and kewde via 0ae7d57 April 24, 2024 12:59
@feri42 feri42 force-pushed the f/support-for-schnorr branch from cb7d1e1 to 0ae7d57 Compare April 24, 2024 12:59
@feri42
Copy link
Contributor Author

feri42 commented Apr 24, 2024

in addition to pass key, this new key chain would reduce the desktop signing process to bare bone right? Removing all of this wallet code

Yes it would! 😁

mvayngrib
mvayngrib previously approved these changes Apr 24, 2024
View reviewed changes
features/keychain/module/__tests__/schnorr.test.js Outdated Show resolved Hide resolved
features/keychain/module/__tests__/schnorr.test.js Outdated Show resolved Hide resolved
fboucquez
fboucquez approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@fboucquez fboucquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@feri42 feri42 requested review from mvayngrib and kewde April 25, 2024 15:08
kewde
kewde approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@kewde kewde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@feri42 feri42 force-pushed the f/support-for-schnorr branch from e458423 to 88406f1 Compare April 26, 2024 07:04
sparten11740
sparten11740 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@sparten11740 sparten11740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

features/keychain/module/crypto/secp256k1.js Show resolved Hide resolved
@mvayngrib mvayngrib merged commit 4c9420d into master Apr 26, 2024
7 checks passed
@mvayngrib mvayngrib deleted the f/support-for-schnorr branch April 26, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparten11740 sparten11740 sparten11740 approved these changes

@fboucquez fboucquez fboucquez approved these changes

@kewde kewde kewde approved these changes

@diegomura diegomura Awaiting requested review from diegomura diegomura is a code owner

@mvayngrib mvayngrib Awaiting requested review from mvayngrib mvayngrib is a code owner

Assignees

@feri42 feri42

Labels
feature keychain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@feri42 @mvayngrib @sparten11740 @fboucquez @kewde