-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: bump basic-utils #138
Conversation
lint failing |
Same issue that lead to bumping eslint in hydra. I might need to do the same in this monorepo |
d69cab6
to
e9c562a
Compare
@diegomura what's the status here? |
This fails because of eslint again 😞 Need to bump to eslint@9 here, will try to do soon |
just disable the prefer-basic-utils eslint rule, it's trying to synchronously require basic-utils apparently anyway, not having that lint rule for 2 packages here is better than not having basic-utils update |
we'll be absorbing this repo into hydra in a few months, so i wouldn't waste too much time on lint setup @diegomura , disabling the rule sounds fine |
Then definitely not worths bumping to eslint9 here. We can bump basic-utils once the merge happens |
here, i fixed it |
Sounds good. Didn't download the other messages when I replied above. You guys are too fast |
Towards using same lib versions in client