Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bump basic-utils #138

Merged
merged 3 commits into from
Sep 30, 2024
Merged

refactor: bump basic-utils #138

merged 3 commits into from
Sep 30, 2024

Conversation

diegomura
Copy link
Contributor

Towards using same lib versions in client

@mvayngrib
Copy link
Collaborator

lint failing

@diegomura
Copy link
Contributor Author

Same issue that lead to bumping eslint in hydra. I might need to do the same in this monorepo

@mvayngrib
Copy link
Collaborator

@diegomura what's the status here?

@diegomura
Copy link
Contributor Author

This fails because of eslint again 😞 Need to bump to eslint@9 here, will try to do soon

@ChALkeR
Copy link
Contributor

ChALkeR commented Sep 30, 2024

just disable the prefer-basic-utils eslint rule, it's trying to synchronously require basic-utils apparently
or add basic-utils@2 dev-dep to the top-level package.json and check if that does the trick

anyway, not having that lint rule for 2 packages here is better than not having basic-utils update

@mvayngrib
Copy link
Collaborator

we'll be absorbing this repo into hydra in a few months, so i wouldn't waste too much time on lint setup @diegomura , disabling the rule sounds fine

@diegomura
Copy link
Contributor Author

Then definitely not worths bumping to eslint9 here. We can bump basic-utils once the merge happens

@ChALkeR
Copy link
Contributor

ChALkeR commented Sep 30, 2024

here, i fixed it

@diegomura
Copy link
Contributor Author

Sounds good. Didn't download the other messages when I replied above. You guys are too fast

@diegomura diegomura enabled auto-merge (squash) September 30, 2024 19:00
@diegomura diegomura merged commit 967abe0 into master Sep 30, 2024
7 checks passed
@diegomura diegomura deleted the dm/bump-libs branch September 30, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants