feat: add common signature encoding #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvayngrib
reviewed
Jun 25, 2024
feri42
changed the title
kewde
reviewed
Jul 1, 2024
|
|
||
| const r = Buffer.from(sig.r.toArray('be', 32)) | ||
| const s = Buffer.from(sig.s.toArray('be', 32)) | ||
| return Buffer.concat([r, s, Buffer.from([sig.recoveryParam])]) |
There was a problem hiding this comment.
Is this the same order in which ethereum expects them? Is there some standard format that defines this?
There was a problem hiding this comment.
The order is the same, however with ETH the recovery param is not included in the binary part: https://github.com/ExodusMovement/assets/blob/690593e3a17d8465a10d3b3b0f669742d60f7b15/ethereum/ethereum-lib/src/unsigned-tx/sign-unsigned-tx.js#L18
|
@mvayngrib , @kewde are you guys OK with this? I already have 4 assets that follow this pattern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This signature encoding seems to be popping up frequently. I'm wondering if we should include it here.
The binary encoding comes in handy so far for: filecoin, theta, tron, vechain, ...