Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type for keyType in KeyIdentifier #102

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: type for keyType in KeyIdentifier #102

merged 1 commit into from
May 8, 2024

Conversation

sparten11740
Copy link
Contributor

Type was missing the k in secp256k1

@sparten11740 sparten11740 requested a review from kewde May 8, 2024 12:09
@sparten11740 sparten11740 self-assigned this May 8, 2024
mvayngrib
mvayngrib approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@mvayngrib mvayngrib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sparten11740 sparten11740 merged commit fa0fa7a into master May 8, 2024
7 checks passed
@sparten11740 sparten11740 deleted the sparten11740/fix/key-type-secp256k1 branch May 8, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvayngrib mvayngrib mvayngrib approved these changes

@kewde kewde Awaiting requested review from kewde

@diegomura diegomura Awaiting requested review from diegomura diegomura is a code owner

Assignees

@sparten11740 sparten11740

Labels
key-identifier library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sparten11740 @mvayngrib