-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction signing capabilities #67
Conversation
while testing with this branch found a few very minor things which may not be related to this PR:
|
This is true. If you don't provide the default address you MUST specify MyERC20Token.name()
|> Ethers.call(to: "0xContract Address Here") If this is not well communicated in the docs maybe we should improve them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-Authored-By: Raz <[email protected]>
Co-Authored-By: Wen Chen <[email protected]>
Co-Authored-By: Wen Chen <[email protected]>
This PR adds the following features to Ethers:
Signer
behaviour which has mandatory callbacks for listing accounts and signing transactions.Signer.Local
: A local signer which signs transactions and lists accounts (a single account) using a 256bit private key.Signer.JsonRPC
: A signer which delegates the transaction signing to a RPC server (like web3siger or geth) using theeth_signTransaction
andeth_accounts
functions.Ethers.sign_transaction/2
function which returns signed payload of a transaction.signer
andsigner_opts
options inEthers.send/2
andEthers.deploy/2
functions.Closes fortelabsinc#1