Add Adapter for RPC client #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaop21
force-pushed
the
js/rpc-client-adapter
branch
from
1c11bec to
acf5644
Compare
|
Thank you @joaop21 this looks very good. I would rather to also be backwards compatible with Thanks again. |
joaop21
commented
Nov 19, 2024
joaop21
force-pushed
the
js/rpc-client-adapter
branch
from
ed01dcf to
c1a63d9
Compare
|
@alisinabh I think it's done on my side 👌 |
alisinabh
reviewed
Nov 20, 2024
|
Also according to tests, |
|
Thank you for the contribution 💚 💜 |
|
hey @alisinabh thank you for making the required changes 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
There is an implicit coupling with
ethereumex, which causes bad decisions to spread fromethereumextoelixir_ethers, which is not desirable at all.How:
By implementing an adapter for
Ethereumexthat formats and transforms inputs so that they are digested correctly byethereumex.Resolves: #151