-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added GameObject and Transform properties to AdminToy #431
base: dev
Are you sure you want to change the base?
Conversation
/// <summary> | ||
/// Gets the <see cref="UnityEngine.GameObject"/> of the target. | ||
/// </summary> | ||
public GameObject GameObject => Base.gameObject; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove breaking change
Make it obsolete pls |
No point in doing so - it's impossible to reference the new property as it is hidden by the backward compatible one. |
Why we even need this property if we have absolutely same in parent class? |
Because @louis1706 asked me to remove breaking changes |
I already said you bruh on discord |
Make it obsolete??? Why we need to have same property? Make it obsolete and remove in next major release. I'm not asking to remove it now, just make devs to know that soon property will be removed |
Again, there is no point in making it obsolete as devs WON'T be able to reference the new one in any case. They will just have the warning without being able to do anything about it. |
Description
Describe the changes
Added GameObject and Transform properties to AdminToy for convinience
What is the current behavior? (You can also link to an open issue here)
Transform and GameObject have to be accesses through .Base (e.g. primitive.Base.transform)
What is the new behavior? (if this is a feature change)
Transform and GameObject can be accessed directly through Exiled AdminToys
Types of changes
Submission checklist
Other