Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added GameObject and Transform properties to AdminToy #431

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Banalny-Banan
Copy link

Description

Describe the changes
Added GameObject and Transform properties to AdminToy for convinience

What is the current behavior? (You can also link to an open issue here)
Transform and GameObject have to be accesses through .Base (e.g. primitive.Base.transform)

What is the new behavior? (if this is a feature change)
Transform and GameObject can be accessed directly through Exiled AdminToys


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Other

  • Still requires more testing

Comment on lines 69 to 73
/// <summary>
/// Gets the <see cref="UnityEngine.GameObject"/> of the target.
/// </summary>
public GameObject GameObject => Base.gameObject;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove breaking change

@VALERA771
Copy link

Make it obsolete pls

@Banalny-Banan
Copy link
Author

Make it obsolete pls

No point in doing so - it's impossible to reference the new property as it is hidden by the backward compatible one.

@VALERA771
Copy link

Why we even need this property if we have absolutely same in parent class?

@Banalny-Banan
Copy link
Author

Why we even need this property if we have absolutely same in parent class?

Because @louis1706 asked me to remove breaking changes

@louis1706
Copy link

Why we even need this property if we have absolutely same in parent class?

I already said you bruh on discord

@VALERA771
Copy link

Make it obsolete??? Why we need to have same property? Make it obsolete and remove in next major release. I'm not asking to remove it now, just make devs to know that soon property will be removed

@Banalny-Banan
Copy link
Author

Make it obsolete??? Why we need to have same property? Make it obsolete and remove in next major release. I'm not asking to remove it now, just make devs to know that soon property will be removed

Again, there is no point in making it obsolete as devs WON'T be able to reference the new one in any case. They will just have the warning without being able to do anything about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants