Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add SCP-1344 Effect to IsPositive Extension #426

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

TtroubleTT
Copy link

@TtroubleTT TtroubleTT commented Feb 2, 2025

Description

Describe the changes

  • Added SCP-1344 to IsPositive Extension for effects.

What is the current behavior? (You can also link to an open issue here)

  • SCP-1344 isn't part of IsPositive even though its a positive effect.

What is the new behavior? (if this is a feature change)

  • SCP-1344 effect is now part of IsPositive.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Misfiy
Copy link
Member

Misfiy commented Feb 5, 2025

its classified as mixed

@TtroubleTT
Copy link
Author

its classified as mixed

Then why is 207, anti 207, and 1853 classified as positive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants