Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed npc health #420

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

fix: fixed npc health #420

wants to merge 5 commits into from

Conversation

Bonjemus
Copy link

Description

Describe the changes
https://discord.com/channels/656673194693885975/1300857604620161064
NPC's health works correctly.

What is the current behavior? (You can also link to an open issue here)
NPC's health was always at 0, the custom health stat did nothing.

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes.
HumeShieldStat is now obsolete.

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Bonjemus
Copy link
Author

Bonjemus commented Feb 1, 2025

Copy link

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that nothing will be broken

EXILED/Exiled.API/Features/Player.cs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants