Skip to content

Commit

Permalink
Make timeout messages distinct
Browse files Browse the repository at this point in the history
... so that we can confirm that it's actually the poll() call that's
timing out.

Bug: 332593241
Test: Treehugger
Change-Id: I529be76a268d7ba1f7f26a953eb84945f3ac4924
  • Loading branch information
hboehm committed Jul 4, 2024
1 parent 95a9a43 commit d9d7f7a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions debuggerd/client/debuggerd_client.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ bool debuggerd_trigger_dump(pid_t tid, DebuggerdDumpType dump_type, unsigned int

auto remaining = end - std::chrono::steady_clock::now();
if (remaining < decltype(remaining)::zero()) {
log_error(output_fd, 0, "timeout expired");
log_error(output_fd, 0, "timeout expired (update_timeout)");
return false;
}

Expand Down Expand Up @@ -254,7 +254,7 @@ bool debuggerd_trigger_dump(pid_t tid, DebuggerdDumpType dump_type, unsigned int
if (timeout_ms <= 0) {
remaining_ms = -1;
} else if (remaining_ms < 0) {
log_error(output_fd, 0, "timeout expired");
log_error(output_fd, 0, "timeout expired before poll");
return false;
}

Expand All @@ -271,7 +271,7 @@ bool debuggerd_trigger_dump(pid_t tid, DebuggerdDumpType dump_type, unsigned int
return false;
}
} else if (rc == 0) {
log_error(output_fd, 0, "timeout expired");
log_error(output_fd, 0, "poll timeout expired");
return false;
}

Expand Down

0 comments on commit d9d7f7a

Please sign in to comment.