Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gnome wacom configuration #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

catskul
Copy link
Contributor

@catskul catskul commented May 10, 2020

Get remarkable mouse to work with the normal wacom tablet settings in gnome control center

…nome-control-center/ubuntu. 'pen' in the name was apparently important
@catskul catskul mentioned this pull request May 10, 2020
@catskul catskul force-pushed the catskul/feat-gnome-wacom-configuration branch from e8976bd to 6a7251f Compare May 10, 2020 08:20
@catskul
Copy link
Contributor Author

catskul commented Jun 5, 2020

I can rebase this to drop the merge commit if it's desired.

@Evidlo
Copy link
Owner

Evidlo commented Jun 5, 2020

Let's auto install the config on startup.

Something like this would go inside remarkable_mouse.py if --evdev is used:

from pathlib import Path
import shutil

libwacom = Path('/usr/share/libwacom')
config = Path(__file__).joinpath('remarkable.tablet')
dest_config = libwacom.joinpath('remarkable.tablet')

if libwacom.exists() and not dest_config.exists():
    shutil.copy(config, dest_config)

You'll need to adjust setup.py so that remarkable.tablet ships with the distribution. Example: https://github.com/Evidlo/passhole/blob/master/setup.py#L10

@catskul
Copy link
Contributor Author

catskul commented Jun 6, 2020

Rewriting my comment after re-reading your comment:

Isn't it a bit odd to copy the file on start rather that copy on install?
Should we be concerned about writing to the system directories when the user might not expect it?
Should we overwrite existing install on re-install?
Should we implement the libwacom file install as a separate script?

Any thought's on those items before I implement the install step?

@Evidlo
Copy link
Owner

Evidlo commented Jul 13, 2020

Isn't it a bit odd to copy the file on start rather that copy on install?

I've asked this question when installing config files for other CLI programs I've written and the advice I've always gotten is to install these files at runtime.

Should we be concerned about writing to the system directories when the user might not expect it?

As long as you do it in a responsible way, it should be fine. Just check if the file already exists.

Should we overwrite existing install on re-install?

I would say no.

Should we implement the libwacom file install as a separate script?

I say keep things simple for the user.

@Evidlo
Copy link
Owner

Evidlo commented Oct 22, 2020

I can merge this as soon as the changes are implemented.

@catskul
Copy link
Contributor Author

catskul commented Oct 22, 2020

I haven't had time to address the PR comments unfortunately. I'll put it in my queue of things I might do this weekend, but I don't know how likely it is.

@chabad360
Copy link
Contributor

chabad360 commented Oct 23, 2020

I should mention, I didn't manage to get this working... oops, just needed a reboot.

@chabad360
Copy link
Contributor

I am curious if it's possible to capture the buttons to use them for the stylus button one and two, as that's the only feature really missing for me.

@Evidlo
Copy link
Owner

Evidlo commented Oct 23, 2020

I am curious if it's possible to capture the buttons to use them for the stylus button one and two, as that's the only feature really missing for me.

Might be possible, though that should go in a separate issue.

Height=8
IntegratedIn=
#Layout=
Styli= #FIXME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styli should be set to 0xffffe;0xffffff;.

See here.

@chabad360
Copy link
Contributor

I've asked this question when installing config files for other CLI programs I've written and the advice I've always gotten is to install these files at runtime.

I would argue that the keyword here is config, but remarkable.tablet isn't meant to be edited by the user, and therefore it's not a config file and should be installed at setup, not first run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants