-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: convert setup.py to pyproject.toml #18
Conversation
Changed Files
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
- Coverage 97.32% 96.88% -0.44%
==========================================
Files 4 5 +1
Lines 224 225 +1
==========================================
Hits 218 218
- Misses 6 7 +1 ☔ View full report in Codecov by Sentry. |
539dc54
to
2b2eee3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Samuel Larkin <[email protected]>
PR Goal?
Modernize the installation procedure for this module too.
Fixes?
The fact that pip 25 won't support setup.py anymore.
Feedback sought?
Make sure it's all OK and all the values I declared in each field are accurate.
Priority?
low
Tests added?
n/a
How to test?
pip install -e .
andpip install -e .[dev]
in wav2vec2aligner.python -m build --sdist --wheel
before and after produce the correct wheel and tar ball.Confidence?
medium-high
Version change?
Yes, because if you're installed before, you will have gotten version
0.0.<date>
, so now I'm making it0.1.0
so the newer install has a higher version number.Related PRs?
EveryVoiceTTS/DeepForcedAligner#33
EveryVoiceTTS/FastSpeech2_lightning#108
EveryVoiceTTS/HiFiGAN_iSTFT_lightning#48
EveryVoiceTTS/EveryVoice#632