Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: convert setup.py to pyproject.toml #18

Merged
merged 2 commits into from
Feb 11, 2025
Merged

build: convert setup.py to pyproject.toml #18

merged 2 commits into from
Feb 11, 2025

Conversation

joanise
Copy link
Member

@joanise joanise commented Feb 4, 2025

PR Goal?

Modernize the installation procedure for this module too.

Fixes?

The fact that pip 25 won't support setup.py anymore.

Feedback sought?

Make sure it's all OK and all the values I declared in each field are accurate.

Priority?

low

Tests added?

n/a

How to test?

pip install -e . and pip install -e .[dev] in wav2vec2aligner.

python -m build --sdist --wheel before and after produce the correct wheel and tar ball.

Confidence?

medium-high

Version change?

Yes, because if you're installed before, you will have gotten version 0.0.<date>, so now I'm making it 0.1.0 so the newer install has a higher version number.

Related PRs?

EveryVoiceTTS/DeepForcedAligner#33
EveryVoiceTTS/FastSpeech2_lightning#108
EveryVoiceTTS/HiFiGAN_iSTFT_lightning#48

EveryVoiceTTS/EveryVoice#632

Copy link

semanticdiff-com bot commented Feb 4, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  aligner/_version.py  0% smaller
  pyproject.toml Unsupported file format
  requirements.dev.txt Unsupported file format
  requirements.txt Unsupported file format
  setup.py  0% smaller

Copy link

github-actions bot commented Feb 4, 2025

CLI load time: 0:00.16
Pull Request HEAD: ee9e8e5407af18f0609f3fbd9a72a834b04bc578
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:       292 |     114193 |   typer
import time:       338 |     120944 | aligner.cli

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.88%. Comparing base (9b9d109) to head (ee9e8e5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
aligner/_version.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   97.32%   96.88%   -0.44%     
==========================================
  Files           4        5       +1     
  Lines         224      225       +1     
==========================================
  Hits          218      218              
- Misses          6        7       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SamuelLarkin SamuelLarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joanise joanise merged commit a002a23 into main Feb 11, 2025
4 of 6 checks passed
@joanise joanise deleted the dev.ej/pyproject branch February 11, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants