feat: add basic optional support for global style token module #100
Conversation
|
Review changes with Changed Files
|
roedoejet
force-pushed
the
dev.ap/gst
branch
from
3bdfd24 to
a48dcd9
Compare
There was a problem hiding this comment.
If you rebase this PR and push, you'll get CI to run unit tests on this PR in the fs2 module, and you'll get code coverage analysis here.
Copyright issues - see inline comments.
I have reviewed this PR for code integration, fitting in the repo, and it looks OK on that level, but I don't feel I can review the DL elements.
| # Copyright 2019 Shigeki Karita | ||
| # Apache 2.0 (http://www.apache.org/licenses/LICENSE-2.0) |
There was a problem hiding this comment.
Please update the LICENSE files both in this repo and in EV to list this new exception.
| # Copyright 2020 Nagoya University (Tomoki Hayashi) | ||
| # Sourced from ESPNet2 | ||
| # Apache 2.0 (http://www.apache.org/licenses/LICENSE-2.0) |
There was a problem hiding this comment.
Ditto, needs to be reflected up in both LICENSE files.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 47.01% 44.14% -2.87%
==========================================
Files 22 24 +2
Lines 1489 1656 +167
==========================================
+ Hits 700 731 +31
- Misses 789 925 +136 ☔ View full report in Codecov by Sentry. |
see EveryVoiceTTS/EveryVoice#605