Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Python 3.12 #634

Merged
merged 2 commits into from
Feb 10, 2025
Merged

feat: add support for Python 3.12 #634

merged 2 commits into from
Feb 10, 2025

Conversation

joanise
Copy link
Member

@joanise joanise commented Feb 7, 2025

PR Goal?

Add support for Python 3.12 in EveryVoice

Fixes?

UserDict added its own implementation of get() in Python 3.12 (see https://github.com/python/cpython/pull/17910/files) and that broke our EnumDict. Fixed by adding our implementation of get() in EnumDict too.

Feedback sought?

sanity

Priority?

low

Tests added?

I'm going to add matrix testing, to test this.

Added matrix testing to exercise all the supported Python versions: 3.10 is the main test workflow, and 3.11 and 3.12 in the matrix one, with just unit testing.

How to test?

make a new env with Python 3.12 and play around.

Confidence?

high

Version change?

no

Related PRs?

none

@joanise joanise requested a review from SamuelLarkin February 7, 2025 19:17
Copy link

semanticdiff-com bot commented Feb 7, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  .github/workflows/test.yml  0% smaller
  everyvoice/wizard/utils.py  0% smaller
  pyproject.toml Unsupported file format

@joanise joanise requested a review from roedoejet February 7, 2025 19:17
Copy link
Contributor

github-actions bot commented Feb 7, 2025

CLI load time: 0:00.27
Pull Request HEAD: ad887d9393c5a222ddb2c19fa9ff7348abcb9cf8
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1112 |     104773 |     typer.main
import time:       299 |     124183 |   typer
import time:      7847 |     203481 | everyvoice.cli

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.24%. Comparing base (110eaad) to head (ad887d9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
+ Coverage   76.23%   76.24%   +0.01%     
==========================================
  Files          47       47              
  Lines        3488     3490       +2     
  Branches      481      481              
==========================================
+ Hits         2659     2661       +2     
  Misses        726      726              
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joanise
Copy link
Member Author

joanise commented Feb 7, 2025

Fixes #329
We had already upgraded torch, which was the biggest barrier, this PR fixes a minor bug and declares Python 3.12 compatibility.

@joanise joanise linked an issue Feb 7, 2025 that may be closed by this pull request
Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I've tested 3.12 separately and it works fine.

@joanise joanise merged commit 6138d94 into main Feb 10, 2025
10 checks passed
@joanise joanise deleted the dev.ej/py312 branch February 10, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We're not currently compatible with Python 3.12
2 participants