-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Python 3.12 #634
Conversation
Changed Files
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 76.23% 76.24% +0.01%
==========================================
Files 47 47
Lines 3488 3490 +2
Branches 481 481
==========================================
+ Hits 2659 2661 +2
Misses 726 726
Partials 103 103 ☔ View full report in Codecov by Sentry. |
Fixes #329 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I've tested 3.12 separately and it works fine.
PR Goal?
Add support for Python 3.12 in EveryVoice
Fixes?
UserDict added its own implementation of
get()
in Python 3.12 (see https://github.com/python/cpython/pull/17910/files) and that broke our EnumDict. Fixed by adding our implementation ofget()
in EnumDict too.Feedback sought?
sanity
Priority?
low
Tests added?
I'm going to add matrix testing, to test this.Added matrix testing to exercise all the supported Python versions: 3.10 is the main test workflow, and 3.11 and 3.12 in the matrix one, with just unit testing.
How to test?
make a new env with Python 3.12 and play around.
Confidence?
high
Version change?
no
Related PRs?
none