Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acronym #22

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Add acronym #22

merged 5 commits into from
Feb 8, 2024

Conversation

slothservice
Copy link
Contributor

  • Add an optional "acronym" field to the terms.
  • Add the acronym to the webpage.

Screenshot 2024-02-01 at 10 45 38 PM

@slothservice slothservice linked an issue Feb 1, 2024 that may be closed by this pull request
Copy link

@hmscheng hmscheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few changes to term translations and a term name.

terms.toml Show resolved Hide resolved
terms.toml Outdated Show resolved Hide resolved
terms.toml Outdated Show resolved Hide resolved
terms.toml Outdated Show resolved Hide resolved
terms.toml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@slothservice slothservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hmscheng,
Thanks for the review. I've addressed all the feedback. Please take a look.

terms.toml Show resolved Hide resolved
terms.toml Show resolved Hide resolved
terms.toml Outdated Show resolved Hide resolved
terms.toml Outdated Show resolved Hide resolved
terms.toml Outdated Show resolved Hide resolved
terms.toml Outdated Show resolved Hide resolved
@slothservice
Copy link
Contributor Author

@hmscheng Thanks for the review!

@slothservice slothservice merged commit acfe122 into main Feb 8, 2024
1 check passed
@slothservice slothservice deleted the add-acronym branch February 8, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helpful fields to add
2 participants