Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS updates for all card versions #522

Merged
merged 3 commits into from
Jan 15, 2025
Merged

JS updates for all card versions #522

merged 3 commits into from
Jan 15, 2025

Conversation

anu13297
Copy link
Contributor

@anu13297 anu13297 commented Jan 15, 2025

  • Eliminated redundant code from the tabs block, ensuring the cards block now loads as expected, utilizing only the relevant JS and CSS for the cards.
  • Refactored JS to ensure consistent title updates to H3 across all card versions.
  • This PR ensures that all card versions are fully functional and display as expected.

Fix #178

Test URLs:

Pages with cards(multiple versions):

Cards block inside Tabs component
http://main--esri-eds--esri.aem.live/en-us/about/about-esri/americas#esri-events

Copy link

aem-code-sync bot commented Jan 15, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@anu13297 anu13297 changed the title JS updates all card versions JS updates for all card versions Jan 15, 2025
Copy link

aem-code-sync bot commented Jan 15, 2025

Page Scores Audits Google
📱 /en-us/about/about-esri/americas PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /en-us/about/about-esri/americas PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@anu13297 anu13297 merged commit a978784 into main Jan 15, 2025
1 of 2 checks passed
@anu13297 anu13297 deleted the cards branch January 15, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure tabs containing cards are displayed correctly (check all screen sizes)
2 participants