Cherry picks from celestia #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enqueue transactions to espresso as soon as they arrive * Multiple submitted transactions * Add the enqueue to AddBroadcastMessages * add messages in write messages so that we can include all messages * add debug log --------- Co-authored-by: Jeremy <[email protected]>
* Enqueue transactions to espresso as soon as they arrive * Multiple submitted transactions (cherry picked from commit 53ab629) * Fix * Resubmit espresso txns * add log for better debugging * add tests and fix some logical errors * fix comments * fix comments * address review comments * go back to old test design to make it explicit --------- Co-authored-by: Sneh Koul <[email protected]>
* Store last position in batch * fix merge conflict * fix build * re-run ci * Fix broken CI * Modify batch poster to increase upper bound of batch if we only have useless messages in the batch * Address PR feedback and run make fmt * Update default test to have larger max size for its batches and poll for finality every 2 seconds. * Update batch poster flow to check validation after we accumulate the batch. * Remove log that could erroneously suggest espresso validation had been performed on a batch * Move log to less spammy location * Update outdated comment * Respond to review feedback --------- Co-authored-by: Zach Showalter <[email protected]>
* Add better logging to batch poster surrounding posting due to max delay * Add start message
* Poll to resubmit transactions * fix comment * fix comment
#453) * Update write logic to add logs and make sure that the message is always enqueued to Espresso * remove HasNotSubmitted * remove HasNotSubmitted * remove HasNotSubmitted
ImJeremyHe
requested review from
alysiahuggins,
zacshowa,
Sneh1999,
sveitser and
jbearer
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.