Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vbs support #32

Merged
merged 15 commits into from
Mar 19, 2024
Merged

Adding vbs support #32

merged 15 commits into from
Mar 19, 2024

Conversation

nyospe
Copy link
Contributor

@nyospe nyospe commented Feb 29, 2024

No description provided.

@nyospe nyospe requested review from jbearer and move47 February 29, 2024 15:29
@nyospe
Copy link
Contributor Author

nyospe commented Feb 29, 2024

@@ -10,9 +10,10 @@ async-trait = "0.1"
clap = { version = "4.4", features = ["derive", "env"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a version bump here and types tag changed. I'll re-approve (if needed) when the conflict fixes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running CI now.

@nyospe nyospe marked this pull request as ready for review March 19, 2024 16:37
@nyospe nyospe merged commit ecc3f6e into main Mar 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants