-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POS efficient l1 polling #2506
Draft
tbro
wants to merge
19
commits into
main
Choose a base branch
from
tb/pos/efficient-l1-polling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
POS efficient l1 polling #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ##2491 Begin to add chunked fetching of stake table events.
* try to get tables in `get_stake_tables` * if not available get events from contract
And some cleanup
And have it return `Option`
Pass fetch_stake_tables test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ##2491
This PR:
Asynchronously updates stake table cache by listening for
L1Event::NewHead
. This happens in a second update loop thread (added toL1Client.update_tasks
). On each such event, stake table events starting atL1State.snapshot.head
and ending on the block received in theNewHead
event. This should be safe sinceL1State.snapshot.head
in initialized to 0. So the first such event will be a large update from block0
to currenthead
. Following updates will be small.