Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotshot 0.5.83 #2361

Merged
merged 153 commits into from
Jan 13, 2025
Merged

Hotshot 0.5.83 #2361

merged 153 commits into from
Jan 13, 2025

Conversation

tbro
Copy link
Contributor

@tbro tbro commented Dec 5, 2024

Mostly Proof of Stake updates. Includes Hotshot w/ preliminary epochs and Leaf2 and related types (currently no-op).

Also:

  • Membership trait update
  • Membership implementation (stake table cache).

sveitser and others added 21 commits November 25, 2024 15:16
Missing conversion from G2 Affine to BLSPubKey.
- Update bindings.
- Add tests for event emission.
- The stake table isn't useful without stakers I think it makes sense to
  require it to be provided on deployment.
We will add some more ergonomic code for conversion to jellyfish at some
point. This code can be used as a stop gap until then.
breaks if we use: `serde.workspace = true`
@tbro tbro changed the title boilerplate Fetch Stake Table Dec 5, 2024
@tbro tbro mentioned this pull request Dec 5, 2024
@tbro tbro self-assigned this Dec 5, 2024
types/src/v0/impls/l1.rs Outdated Show resolved Hide resolved
sveitser and others added 4 commits December 6, 2024 17:15
Branched from #2325. Adds most everything from #2237. Main blocker now is to iron out
`ChainConfig` versions. Then we can get into the actual stake table
retrieval logic.
Builds on #2361 reworks many things for realistic use in our current
code-base.
@imabdulbasit imabdulbasit marked this pull request as draft January 8, 2025 18:22
ss-es
ss-es previously requested changes Jan 8, 2025
Copy link
Contributor

@ss-es ss-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only had a quick look at a few things, seems fine to me overall

I think the compat test changes should be reverted though

data/v1/messages.json Outdated Show resolved Hide resolved
sequencer/src/message_compat_tests.rs Outdated Show resolved Hide resolved
@tbro tbro marked this pull request as ready for review January 10, 2025 15:52
@tbro tbro changed the title Fetch Permissioned Stake Table from L1 Hotshot Proof of Stake Update Jan 10, 2025
@ss-es ss-es dismissed their stale review January 10, 2025 16:45

addressed

@@ -182,6 +181,9 @@ pub type FeeVersion = StaticVersion<0, 2>;
pub type MarketplaceVersion = StaticVersion<0, 99>;
pub type EpochVersion = StaticVersion<0, 100>;

// TODO: >>>>>???
pub const EPOCH_HEIGHT: u64 = 10000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. For some reason compile times have shot up, and I its causing pains testing small changes like this. So I'm going to merge and we can remove this in a Followup.

@tbro tbro changed the title Hotshot Proof of Stake Update Hotshot 0.5.83 Jan 13, 2025
@tbro tbro merged commit f7b8eca into main Jan 13, 2025
22 of 23 checks passed
@tbro tbro deleted the tb/pos/fetch-stake-table2 branch January 13, 2025 19:43
@tbro tbro mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants