-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotshot 0.5.83 #2361
Hotshot 0.5.83 #2361
Conversation
Missing conversion from G2 Affine to BLSPubKey.
- Update bindings. - Add tests for event emission.
- The stake table isn't useful without stakers I think it makes sense to require it to be provided on deployment.
We will add some more ergonomic code for conversion to jellyfish at some point. This code can be used as a stop gap until then.
Co-authored-by: Alysia Tech <[email protected]>
breaks if we use: `serde.workspace = true`
Builds on #2361 reworks many things for realistic use in our current code-base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only had a quick look at a few things, seems fine to me overall
I think the compat test changes should be reverted though
This reverts commit 5cfa92d.
Fixes error in type update
Remove epoch number where possible
rust updated to 1.84
@@ -182,6 +181,9 @@ pub type FeeVersion = StaticVersion<0, 2>; | |||
pub type MarketplaceVersion = StaticVersion<0, 99>; | |||
pub type EpochVersion = StaticVersion<0, 100>; | |||
|
|||
// TODO: >>>>>??? | |||
pub const EPOCH_HEIGHT: u64 = 10000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. For some reason compile times have shot up, and I its causing pains testing small changes like this. So I'm going to merge and we can remove this in a Followup.
- Add `ExplorerTransaction.payload_size` impl
Add dummy impl for `Transaction.payload_size`
Mostly Proof of Stake updates. Includes Hotshot w/ preliminary epochs and
Leaf2
and related types (currently no-op).Also:
Membership
trait updateMembership
implementation (stake table cache).