Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll L1 more rapidly when we expect a block to be ready soon #2167

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Poll L1 more rapidly when we expect a block to be ready soon #2167

merged 1 commit into from
Oct 11, 2024

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented Oct 11, 2024

Closes #2164

This PR:

  • Increases the rate of polling for L1 blocks when we expect the desired block to be ready soon. This should avoid situations where we block in proposal validation for a long time when a block is just about to be ready, and thus fall behind in consensus
  • Continues to poll at the default provider interval when we expect the block not to be ready for a long time. This should save us some Infura usage when, for example, waiting for the L1 genesis to be ready before starting the network

@jbearer jbearer merged commit b70b7bd into main Oct 11, 2024
15 checks passed
@jbearer jbearer deleted the jb/l1-polling-interval branch October 11, 2024 22:04
github-actions bot pushed a commit that referenced this pull request Oct 11, 2024
@jbearer @github-actions
Poll L1 more rapidly when we expect a block to be ready soon (#2167)
4231ace 
Closes #2164

(cherry picked from commit b70b7bd)
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-gambit:

@github-actions github-actions bot mentioned this pull request Oct 11, 2024
Merged
jbearer added a commit that referenced this pull request Oct 11, 2024
@github-actions @jbearer
[Backport release-gambit] Poll L1 more rapidly when we expect a block…
59ce2d7 
… to be ready soon (#2168)

Poll L1 more rapidly when we expect a block to be ready soon (#2167)

Closes #2164

(cherry picked from commit b70b7bd)

Co-authored-by: Jeb Bearer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imabdulbasit imabdulbasit imabdulbasit approved these changes

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@tbro tbro Awaiting requested review from tbro tbro is a code owner

Assignees
No one assigned
Labels
backport release-gambit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set L1 provider polling interval to 1s
2 participants
@jbearer @imabdulbasit