Add upgrade test #2086
Merged
Add upgrade test #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbro
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
imabdulbasit
as code owners
tbro
force-pushed
the
tb/testing/upgrades
branch
from
6a8cd1f to
f654031
Compare
imabdulbasit
reviewed
Oct 7, 2024
imabdulbasit
reviewed
Oct 7, 2024
imabdulbasit
reviewed
Oct 7, 2024
| break; | ||
| } | ||
|
|
||
| if header.height() > SEQUENCER_BLOCKS_TIMEOUT { |
There was a problem hiding this comment.
can we also check that we are producing blocks after the upgrade is successful
imabdulbasit
reviewed
Oct 7, 2024
tbro
force-pushed
the
tb/testing/upgrades
branch
2 times, most recently
from
2bf8dbc to
37f7d17
Compare
Add integration test for upgrades. Collect multiple sequencer streams into one stream and and assert version in the headers. First few blocks are asserted to be base version. Then we check that all the sequencers are upgrade within a timeout period. Currently we only check 2 sequencers, since that is how many have the API enabled currently. The same test can be run against any consecutive base/upgrade version pairs. * factor common logic to module * add sequencer version env var to setting version to be tested * get builder address from API (instead of hard coding)
This reverts commit e42ba14.
tbro
force-pushed
the
tb/testing/upgrades
branch
from
37f7d17 to
504de74
Compare
imabdulbasit
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2053 and #2055
This PR:
Add integration test for upgrades. Collect multiple sequencer streams into one stream and and assert version in the headers. First few blocks are asserted to be base version. Then we check that all the sequencers are upgraded within a timeout period. Currently we only check 2 sequencers, since that is how many have the API enabled currently. The same test can be run against any consecutive base/upgrade version pairs.
SequencerClientto avoid requiring generics