[WEEKLY RELEASE] HotShot - rc-0.5.71 #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-maron
commented
Aug 15, 2024
tbro
requested changes
Aug 20, 2024
rob-maron
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
imabdulbasit
as code owners
rob-maron
commented
Aug 20, 2024
Comment on lines
-198
to
+206
| // TODO this is proabably a mistake in builder-core. These | ||
| // generic params can be removed and the concrete types | ||
| // used instead. | ||
| let res = | ||
| run_non_permissioned_standalone_builder_service::<SeqTypes, SequencerVersions>( | ||
| da_sender, | ||
| qc_sender, | ||
| decide_sender, | ||
| tx_sender, | ||
| events_url, | ||
| ) | ||
| .await; | ||
| let res = run_non_permissioned_standalone_builder_service::<_, SequencerVersions>( | ||
| da_sender, | ||
| qc_sender, | ||
| decide_sender, | ||
| events_url, | ||
| global_state_clone, | ||
| ) | ||
| .await; |
rob-maron
commented
Aug 20, 2024
Comment on lines
506
to
513
| async_spawn(async move { | ||
| run_permissioned_standalone_builder_service( | ||
| tx_sender, | ||
| da_sender, | ||
| qc_sender, | ||
| decide_sender, | ||
| hotshot_handle_clone, | ||
| global_state_clone, | ||
| ) |
There was a problem hiding this comment.
This may also be relevant
tbro
approved these changes
Aug 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.