Attempt to remove function evaluateLagrangeOne. #1827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippecamacho
requested review from
nomaxg,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
philippecamacho
requested review from
alxiong
and removed request for
sveitser,
nomaxg,
jbearer,
ImJeremyHe and
tbro
alxiong
reviewed
Aug 7, 2024
| } | ||
| group = mulmod(group, self.groupGen, p); | ||
| } | ||
| return 0; | ||
| return (0, 0); |
There was a problem hiding this comment.
this is wrong logic btw, when vanishingPolyEval == 0, the zeta could be one of the domain element: if it's the first domain element, then lagrange_1_eval = 1
There was a problem hiding this comment.
Thanks. Some tests still fail though.
I agree, especially after Common Prefix's optimization, the code would look less clear if we removed So let us keep this function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1752
This PR:
Still draft PR. This is an attempt to remove the function evaluateLagrangeOne. While all the Plonk verifier tests are passing, some PolynomialEval tests are still failing. Not clear to me why.