fix: enable retries for integration tests #2749
Merged
+117
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Start process compose with rust. - Set initial block to same block as initial number of txns is taken from.
sveitser
requested review from
jbearer,
tbro,
imabdulbasit,
ss-es,
pls148,
bfish713,
rob-maron and
lukaszrzasik
as code owners
jparr721
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the retries don't work because we start the native demo once then retry the asserts. However if the tests fail it usually means the native demo is not working so we would have to restart it. This PR moves starts the native demo as part of the integration tests, thereby making the tests standalone.
Unfortunately the upgrade test currently never works for me locally, even on
main. edit: it does work on CI though so it's probably me.