Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(marketplace): implement auction results calculation logic #2747

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DeVikingMark
Copy link

This PR:

  • Implements auction results calculation logic in marketplace solver
  • Adds validation for reserve prices in auction bids
  • Adds handling of inactive rollups in auction process
  • Adds comprehensive test suite for auction functionality

This PR does not:

  • Implement shared solver state with HotShot events (tracked in TODO comment, requires separate issue)

Key places to review:

  • marketplace-solver/src/state.rs:
    • calculate_auction_results_permissionless function: Implementation of auction winner selection logic
    • calculate_auction_results_permissioned function: Reuse of permissionless logic with signature verification
  • marketplace-solver/src/testing.rs:
    • New test cases for auction functionality:
      • test_calculate_auction_results_no_bids
      • test_calculate_auction_results_with_bids
      • test_calculate_auction_results_bid_below_reserve
      • test_calculate_auction_results_inactive_rollup

How to test this PR:

  • Run tests: cargo test -p marketplace-solver
  • All new tests are integrated with existing test infrastructure using MockSolver

Things tested

  • Auction winner selection with various bid amounts
  • Reserve price validation
  • Inactive rollup handling
  • Reserve URL fallback for namespaces without valid bids
  • Integration with existing rollup registration system
  • Issue linked or PR description mentions why this change is necessary
  • PR description is clear enough for reviewers
  • Documentation for changes has been updated
  • All changes are covered by tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant