Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Epoch Root via Leaves for Stake Table Catchup #2650

Merged
merged 81 commits into from
Mar 7, 2025
Merged

Conversation

bfish713
Copy link
Contributor

@bfish713 bfish713 commented Feb 20, 2025

This PR implements Leaf fetching to get the epoch root for each epoch we need for catchup.

This PR adds to the CatchupDataSource the ability to fetch leafs from others for use in catchup.

@bfish713 bfish713 changed the base branch from main to bf/st-catchup February 20, 2025 15:54
Copy link
Contributor

Unable to build without Cargo.lock file.

This means that after this change 3rd party projects may have
difficulties using crates in this repo as a dependency. If this
isn't easy to fix please open an issue so we can fix it later.

For the first failing build see: https://github.com/EspressoSystems/espresso-sequencer/actions/runs/13439312026

To reproduce locally run

cargo generate-lockfile
cargo check --all-targets

This PR can still be merged.

Copy link
Contributor

@imabdulbasit imabdulbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it LGTM

.get_epoch_root(root_block_in_epoch(*root_epoch, self.epoch_height))
.await
.ok_or(anytrace::warn!("get epoch root failed"))?;
else {
anytrace::bail!("get epoch root failed");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think its better to know what epoch it failed for

@bfish713 bfish713 requested a review from imabdulbasit March 6, 2025 17:02
Base automatically changed from bf/st-catchup to main March 6, 2025 22:58
@bfish713 bfish713 merged commit a31db38 into main Mar 7, 2025
50 of 51 checks passed
@bfish713 bfish713 deleted the bf/leaf-catchup branch March 7, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants