Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable stake and randomized leader selection #2638

Merged
merged 9 commits into from
Feb 24, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions hotshot-types/src/traits/election.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@
//! The election trait, used to decide which node is the leader and determine if a vote is valid.
use std::{collections::BTreeSet, fmt::Debug, num::NonZeroU64};

use sha2::{Digest, Sha256, Sha512};

use crate::traits::signature_key::StakeTableEntryType;
use async_trait::async_trait;
use hotshot_utils::anytrace::Result;
use primitive_types::{U256, U512};

use super::node_implementation::NodeType;
use crate::{traits::signature_key::SignatureKey, PeerConfig};
Expand Down Expand Up @@ -153,3 +157,78 @@ pub trait Membership<TYPES: NodeType>: Debug + Send + Sync {
None
}
}

/// Calculate `xor(drb.cycle(), public_key)`, returning the result as a vector of bytes
fn cyclic_xor(drb: [u8; 32], public_key: Vec<u8>) -> Vec<u8> {
let drb: Vec<u8> = drb.to_vec();

let mut result: Vec<u8> = vec![];

for (drb_byte, public_key_byte) in public_key.iter().zip(drb.iter().cycle()) {
result.push(drb_byte ^ public_key_byte);
}

result
}

/// Generate the stake table CDF, as well as a hash of the resulting stake table
pub fn generate_stake_cdf<Key: SignatureKey, Entry: StakeTableEntryType<Key>>(
mut stake_table: Vec<Entry>,
drb: [u8; 32],
) -> (Vec<(Entry, U256)>, [u8; 32]) {
// sort by xor(public_key, drb_result)
stake_table.sort_by(|a, b| {
cyclic_xor(drb, a.public_key().to_bytes()).cmp(&cyclic_xor(drb, b.public_key().to_bytes()))
});

let mut hasher = Sha256::new();

let mut cumulative_stake = U256::from(0);
let mut cdf = vec![];

for entry in stake_table {
cumulative_stake += entry.stake();
hasher.update(entry.public_key().to_bytes());

cdf.push((entry, cumulative_stake));
}

(cdf, hasher.finalize().into())
}

/// select the leader for a view
///
/// # Panics
/// Panics if the cdf is empty
pub fn select_randomized_leader<SignatureKey, Entry: StakeTableEntryType<SignatureKey> + Clone>(
cdf: Vec<(Entry, U256)>,
stake_table_hash: [u8; 32],
drb: [u8; 32],
view: u64,
) -> Entry {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be a method of stake table struct or trait, something like StakeTable.next_leader() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it will be! I wanted to separate the raw logic into its own function, but the trait that handles the stake table will implement leader selection by calling this.

we just have multiple implementations that may or may not use this leader selection for tests etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up just creating a wrapper type for all the DRB-related information we want to store between views, and the implementation now uses this opaquely!

// We hash the concatenated drb, view and stake table hash.
let mut hasher = Sha512::new();
hasher.update(drb);
hasher.update(view.to_le_bytes());
hasher.update(stake_table_hash);
let raw_breakpoint: [u8; 64] = hasher.finalize().into();

// then calculate the remainder modulo the total stake as a U512
let remainder: U512 =
U512::from_little_endian(&raw_breakpoint) % U512::from(cdf.last().unwrap().1);

// and drop the top 32 bytes, downcasting to a U256
let breakpoint: U256 = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let mut result = [0u8; 64];

remainder.to_little_endian(&mut result);

U256::from_little_endian(&result[32..64])
};

// now find the first index where the breakpoint is strictly smaller than the cdf
let index = cdf.partition_point(|(_, cumulative_stake)| breakpoint < *cumulative_stake);

// and return the corresponding entry
cdf[index].0.clone()
}
Loading