Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional VID compute field #2631

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Optional VID compute field #2631

merged 3 commits into from
Feb 17, 2025

Conversation

rob-maron
Copy link
Contributor

Makes new nodes backwards compatible with the old builder by accepting a field as optional that is no longer sent

Copy link
Contributor

@ss-es ss-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

I guess we're relying on the fact that any None for an Option<_> serializes the same way?

@rob-maron rob-maron enabled auto-merge (squash) February 17, 2025 19:11
@rob-maron rob-maron merged commit a0087b2 into main Feb 17, 2025
32 checks passed
@rob-maron rob-maron deleted the rm/optional-vid-compute-field branch February 17, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants