Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3917 pull epoch from qc in quorum_proposal::wait_for_qc_event #3955

Merged
merged 1 commit into from
Dec 11, 2024
Merged

3917 pull epoch from qc in quorum_proposal::wait_for_qc_event #3955

merged 1 commit into from
Dec 11, 2024

Conversation

pls148
Copy link
Contributor

@pls148 pls148 commented Dec 11, 2024 •
edited
Loading

Closes #3917

This PR:

Takes epoch from QC in quorum_proposal::wait_for_qc_event

This PR does not:

Key places to review:

@pls148 pls148 requested a review from bfish713 as a code owner December 11, 2024 01:48
@pls148 pls148 marked this pull request as draft December 11, 2024 01:48
@pls148 pls148 marked this pull request as ready for review December 11, 2024 19:04
@pls148 pls148 requested review from tbro and ss-es December 11, 2024 20:06
@pls148 pls148 merged commit 988df91 into main Dec 11, 2024
17 checks passed
@pls148 pls148 deleted the ps/3917 branch December 11, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbro tbro tbro approved these changes

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

@ss-es ss-es Awaiting requested review from ss-es

Assignees

@bfish713 bfish713

@rob-maron rob-maron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

take epoch from QC when wait_for_qc_event
4 participants
@pls148 @tbro @bfish713 @rob-maron