Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random mode #2

Merged
merged 7 commits into from
Aug 1, 2024
Merged

Fix random mode #2

merged 7 commits into from
Aug 1, 2024

Conversation

ErikBlaz
Copy link
Collaborator

This pull request contains the changes that were missing from the previous one, which I accidentally closed. Basically, this version aims to correct the random mode as discussed with @eliamascolo.

@ErikBlaz ErikBlaz requested a review from eliamascolo July 25, 2024 17:35
Copy link
Member

@eliamascolo eliamascolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment in this review.

@ErikBlaz
Copy link
Collaborator Author

In this last commit I solved the opened issues by Elia (#4 & #3) and I changed the sample function implementation, now using np.random.choice.

@eliamascolo eliamascolo merged commit 26b4402 into main Aug 1, 2024
@eliamascolo eliamascolo deleted the develop branch August 1, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants