Upgrade Thirft API version to 0.21.0 #4425
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current thrift version 0.13.0 uses a keyword argument in its implementation for the http.client.HTTPSConnection that is deprecated in Python 3.12 (see: https://docs.python.org/3.12/library/http.client.html#http.client.HTTPSConnection)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of Thrift is quite old, and the generated Python stubs are triggering deprecation warnings in modern Python versions (I tested it with Python 3.12). Additionally, the official Docker image used for compiling Thrift definition files is outdated. To address this, I have introduced a customization point in the build system, making it easier to configure when building the CodeChecker API packages.