Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Getting file counts query #4421

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

cservakt
Copy link
Collaborator

@cservakt cservakt commented Jan 9, 2025

Grouping by the file path takes too long when the user wants to filter the reports by file path filter. The solution can be using distinct insted of group by to get the first ten files considering the report filter as well. Then it is faster to count the number of reports only for these files..

@cservakt cservakt added database 🗄️ Issues related to the database schema. server 🖥️ performance 🏃 labels Jan 9, 2025
@cservakt cservakt added this to the release 6.25.0 milestone Jan 9, 2025
@cservakt cservakt force-pushed the file-path-grouping branch from d5f6af8 to e619af2 Compare January 9, 2025 15:49
@cservakt cservakt added the WIP 💣 Work In Progress label Jan 9, 2025
Grouping by the file path takes too long when the user wants to filter the reports by file path filter.
The solution can be using `distinct` insted of `group by` to get the first ten files considering the report filter as well. Then it is faster to count the number of reports only for these files..
@cservakt cservakt requested review from dkrupp and noraz31 January 10, 2025 15:49
@cservakt cservakt removed the WIP 💣 Work In Progress label Jan 10, 2025
Copy link
Contributor

@bruntib bruntib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should order the results in all queries where limit/offset is used for paging. Currently, this function is not used for paging, but this is an overall comment for all queries in CodeChecker. I'll create a ticket for this issue.

@bruntib bruntib merged commit 6997b66 into Ericsson:master Jan 13, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database 🗄️ Issues related to the database schema. performance 🏃 server 🖥️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants