Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item/Entity/Text Embeds #21

Merged
merged 20 commits into from
Apr 27, 2024
Merged

Item/Entity/Text Embeds #21

merged 20 commits into from
Apr 27, 2024

Conversation

Erdragh
Copy link
Owner

@Erdragh Erdragh commented Apr 18, 2024

Implements:

  • Item embeds if a message has a Component with a SHOW_ITEM hover action
  • Entity embeds if a Component has a SHOW_ENTITY hover action
  • Text embeds if a Component has a SHOW_TEXT hover action

Embed colors are decided by:

  • Item rarity
  • Text embed Component color
  • Green if entity is passive/friendly

This will also implement:

@Erdragh Erdragh added the enhancement New feature or request label Apr 18, 2024
@Erdragh Erdragh self-assigned this Apr 18, 2024
@Erdragh Erdragh marked this pull request as draft April 18, 2024 17:11
@Erdragh Erdragh changed the title Feature/embeds Item/Entity/Text Embeds Apr 18, 2024
@Erdragh
Copy link
Owner Author

Erdragh commented Apr 23, 2024

I now parse Discord messages as Markdown and render them into Minecraft's Chat Component system. This system may break so I expect there to be more issues coming in. I've tested what I could.

There's one thing left I want to do, which is adding more configuration options for the rendering.

@Erdragh Erdragh marked this pull request as ready for review April 27, 2024 07:04
@Erdragh Erdragh merged commit a3dbaa4 into version/1.20.1 Apr 27, 2024
3 checks passed
@Erdragh Erdragh deleted the feature/embeds branch April 27, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant