Runtime and GC fixes related to orbit UI bluescreens (ParadiseSS13#23512

) * GC and runtime fixes * BONUS FIX!
ErdGinalD · Dec 26, 2023 · 3f5c57b · 3f5c57b
1 parent 19cc5e1
commit 3f5c57b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/code/game/gamemodes/objective.dm b/code/game/gamemodes/objective.dm
@@ -49,6 +49,7 @@ GLOBAL_LIST_INIT(potential_theft_objectives, (subtypesof(/datum/theft_objective)
 	owner = null
 	target = null
 	team = null
+	holder = null
 	return ..()
 
 /datum/objective/proc/check_completion()

diff --git a/code/game/gamemodes/objective_holder.dm b/code/game/gamemodes/objective_holder.dm
@@ -20,6 +20,9 @@
 
 /datum/objective_holder/Destroy(force, ...)
 	clear()
+	objective_owner = null
+	QDEL_NULL(on_add_callback)
+	QDEL_NULL(on_remove_callback)
 	return ..()
 
 /**

diff --git a/code/modules/antagonists/traitor/datum_mindslave.dm b/code/modules/antagonists/traitor/datum_mindslave.dm
@@ -27,8 +27,11 @@
 	if(owner.som)
 		owner.som.serv -= owner
 		owner.som.leave_serv_hud(owner)
-	// Remove the reference but turn this into a string so it can still be used in /datum/antagonist/mindslave/farewell().
-	master = "[master.current.real_name]"
+	// Remove the master reference but turn this into a string so it can still be used in /datum/antagonist/mindslave/farewell().
+	if(master.current)
+		master = "[master.current.real_name]"
+	else
+		master = "[master]"
 	return ..()
 
 /datum/antagonist/mindslave/on_gain()