Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make givepoints an alias #1334

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Conversation

ccuser44
Copy link
Contributor

Superseeds #1285

Givepoints is deprecated, this adds backwards compatibility

@Dimenpsyonal Dimenpsyonal added ⚡ command Specific Adonis commands ⌛needs PoF This PR is awaiting proof of functionality 🎏 miscellaneous Miscellaneous content labels Jan 11, 2024
@Dimenpsyonal
Copy link
Member

sadface :(
Will probably merge when Proof of Functionality is given

@ccuser44
Copy link
Contributor Author

sadface :( Will probably merge when Proof of Functionality is given

Works the same as before expect it doesnt show up in suggestions

@ccuser44
Copy link
Contributor Author

Proof of functionality:
image

@Dimenpsyonal
Copy link
Member

can you also attach proof that the playerpoints gui shows up

@ccuser44
Copy link
Contributor Author

can you also attach proof that the playerpoints gui shows up

Yes there is no reason it wouldn't if it calls the same pointservice function with the same args

@Dimenpsyonal Dimenpsyonal removed the ⌛needs PoF This PR is awaiting proof of functionality label Jan 14, 2024
@Dimenpsyonal
Copy link
Member

True

@Dimenpsyonal Dimenpsyonal merged commit caa6b26 into Epix-Incorporated:master Jan 15, 2024
2 checks passed
Dimenpsyonal added a commit that referenced this pull request Jan 15, 2024
* Fix missing $

* Update Functions.lua (#1326)

* Added FPS Command (#1308)

* Added FPS command

* Added the command

* Removed cPcall

* Changed game:getservice() to service

By: SuperCater

Co-authored-by: Cater <[email protected]>

* Update Debug_Specific.lua (#1337)

* Revert regressions introduced in #1313 and #1308 (#1339)

* Merge resetatmosphere to resetlighting (#1340)

* Fix naming error in #1297 (#1341)

* Updates :starterscript + 2 new related commands

This adds a name argument to :starterscript and adds :starterscripts and :removestarterscript <name>

* Fix naming error

* Fixed :Jail bug not unjailing after set time (#1342)

* Update Version to v242

* Update Changelog to v242

* Fix FPS gui (#1338)

* Fix FPS gui

* Update FPS.lua

* Update FPS.lua

* Update Admin.lua (#1343)

* v242 changelog(2)

* Make disabling linkedlists a loader flag (#1335)

* Change linkedlist toggle

* Removed linkedlist toggle from settings

* Make disabling linkedlists a loader flag

* Update Logs.lua

* Improve bug report form (#1345)

* Improve bug report form

* Update Bug_Report.yml

* Fix typo

* Update Changelog version to v242

* Very Big Change (#1349)

* Notify admins what rank they are upon joining (#1303)

* Notify admins what rank they are upon joining

* Use string interpolation

* Update Process.lua

---------

Co-authored-by: Dimenpsyonal <[email protected]>

* Make givepoints an alias (#1334)

* Add legacy aliases of player points

* Remove legacy player poinst command

* Update Variables.lua

* Fix typo

* Update Admin.lua

* Fix typo

* Fix typo

* Update Core.lua

* Finally fix script

* Added in-game Script Editor (#1315)

* Added remote commands

* Update Remote.lua

* Added ScriptEditor command

* Added ScriptEditor UI module

* Added ScriptEditor to variables

* Fixed an error in logging

* Update !playerinfo command - Get Render Resolution (#1287)

* Update Profile.lua - Render Resolution

* Update Functions.lua - Enable getting client render resolution

Uses CurrentCamera.ViewportSize to get the resolution.

* Add new additions: v242 Changelog

---------

Co-authored-by: burger <[email protected]>
Co-authored-by: kaiserandaxl <[email protected]>
Co-authored-by: Cater <[email protected]>
Co-authored-by: ccuser44 <[email protected]>
Co-authored-by: EasternBloxxer <[email protected]>
Co-authored-by: EasternBloxxer <[email protected]>
Co-authored-by: Alistair Lau <[email protected]>
Co-authored-by: Wilson Simanjuntak <[email protected]>
@ccuser44 ccuser44 deleted the patch-12 branch January 17, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ command Specific Adonis commands 🎏 miscellaneous Miscellaneous content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants