Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store local paths as pathlib paths #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EpicWink
Copy link
Owner

Instead of always having the file cache return strings, instead return pathlib.Path instances for local paths, and strings for URLs. This turns the string parsing for URL scheme into simply an isinstance check.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 89.56%. Comparing base (5afcd9e) to head (e57721e).
Report is 1 commits behind head on master.

Files Patch % Lines
src/proxpi/_cache.py 71.42% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   89.45%   89.56%   +0.11%     
==========================================
  Files           3        3              
  Lines         673      661      -12     
==========================================
- Hits          602      592      -10     
+ Misses         71       69       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EpicWink
Copy link
Owner Author

I need to perform benchmarking to see if this increases or reduces latency and server load

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants