-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lp command for one-sided printing #675
Conversation
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe pull request introduces modifications to the print management system, specifically in the Changes
Possibly Related PRs
Suggested Reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
We were including an empty string in the arguments of `lp` when performing one-sided printing. This was interpreted as an additional file to be printed at path "". Also, this API leaves argument splitting to us; how did it even work with `-o` and `sides=two-sided-long-edge` being parsed as a single argument?
3decfc4
to
7dd66dc
Compare
We were including an empty string in the arguments of
lp
whenperforming one-sided printing. This was interpreted as an additional
file to be printed at path "". Also, this API leaves argument splitting
to us; how did it even work with
-o
andsides=two-sided-long-edge
being parsed as a single argument?