convert tile flag to cross-corr flags #327
Open
+29
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is bit complicated. This is in response to issue #311 .
The suggested fix in #311 could be more generalized. For example, the metadata file is actually structured such that the Y pol is before the X pol (why?!?!). Even though we currently flag XX, YY, XY, and YX the same currently doesn't mean we always will want that. Therefore, I've constructed a way that is generalized.
Essentially, the code grabs the individual dipole flags and matches their metadata name (i.e. X) to a component in the cross-correlation name (i.e. XY). Then a logical OR is performed to get the cross-correlation flag.
So, an X-dipole flag will end up flagging XX, XY, and YX. But not YY.
No difference in the 2-pol. Only difference is in 4-pol flagging.
This will need to be implemented in pyFHD (low-priority) -- I will make an issue and link it.