Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow complex and double precision HEALPix #235

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicholebarry
Copy link
Contributor

This branch has the basic requirements for being able to create cross-pol Healpix cubes.

It uses the type of the image to determine the type of the Healpix cube (i.e. double, float, real, complex). However, this results in slightly bulky code...checking the type means using a 4 case statement each time. Is there a better way to do it?

This is also not as efficient as it could be. @rlbyrne I remember you saying that the cross-pols are complex conjugates of one another (I think?). Is this always the case, not just for current code, but for most instrumentation and future parameters? If so, we could potentially get away with only writing out three cubes instead of all four.

@nicholebarry nicholebarry marked this pull request as draft September 25, 2020 04:46
@rlbyrne
Copy link
Contributor

rlbyrne commented Sep 30, 2020

Yes, cross-pols will always be complex conjugates of one another.

I'm concerned about the data volume increase if we make Healpix cubes complex. Does that apply to XX and YY as well? Then those Healpix cubes would be twice the size they need to be. One option is to keep the Healpix cubes real and output XX, YY, the real part of XY, and the imaginary part of XY. This is what we do for the integrated images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants