Skip to content

Commit

Permalink
Run CI against Rails 7.2 (#33)
Browse files Browse the repository at this point in the history
 * Add /gemfiles/vendor/ to .gitignore since the directory is used when installing by using Gemfile under gemfiles/ dir

 * Rails 6.1 or above should use rspec-rails 6.x to comply its policy

   https://github.com/rspec/rspec-rails/blob/d0e322b20bb713b200b66d4a7cc21a272d0b4374/README.md#L11-L16

 * Rails 8.0 require sqlite3 2.0 or above

   rails/rails#51958

 * Add Ruby 3.3 x Rails 7.2 to test matrix
  • Loading branch information
ohbarye authored Aug 19, 2024
1 parent bcb4776 commit fbb1e36
Show file tree
Hide file tree
Showing 9 changed files with 31 additions and 6 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,15 @@ jobs:
- ruby: '3.2'
activerecord: '7.1'
gemfile: 'activerecord_7_1.gemfile'
- ruby: '3.1'
activerecord: '7.2'
gemfile: 'activerecord_7_2.gemfile'
- ruby: '3.2'
activerecord: '7.2'
gemfile: 'activerecord_7_2.gemfile'
- ruby: '3.3'
activerecord: '7.2'
gemfile: 'activerecord_7_2.gemfile'
- ruby: '3.3'
activerecord: 'HEAD'
gemfile: 'activerecord_master.gemfile'
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
/spec/reports/
/tmp/
/gemfiles/*.lock
/gemfiles/vendor/

# rspec failure tracking
.rspec_status
6 changes: 6 additions & 0 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ appraise "activerecord-7-1" do
gem "rspec-rails", "~> 5.0"
end

appraise "activerecord-7-2" do
gem "activerecord", "~> 7.2.0"
gem "sqlite3", "~> 1.4"
gem "rspec-rails", "~> 5.0"
end

appraise "activerecord-master" do
git "https://github.com/rails/rails.git" do
gem "rails"
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
after_commit_everywhere (1.3.1)
after_commit_everywhere (1.4.0)
activerecord (>= 4.2)
activesupport

Expand Down
2 changes: 1 addition & 1 deletion gemfiles/activerecord_6_1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ source "https://rubygems.org"

gem "activerecord", "~> 6.1.0"
gem "sqlite3", "~> 1.4"
gem "rspec-rails", "~> 4.0"
gem "rspec-rails", "~> 6.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/activerecord_7_0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ source "https://rubygems.org"

gem "activerecord", "~> 7.0.0"
gem "sqlite3", "~> 1.4"
gem "rspec-rails", "~> 5.0"
gem "rspec-rails", "~> 6.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/activerecord_7_1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ source "https://rubygems.org"

gem "activerecord", "~> 7.1.0"
gem "sqlite3", "~> 1.4"
gem "rspec-rails", "~> 5.0"
gem "rspec-rails", "~> 6.0"

gemspec path: "../"
9 changes: 9 additions & 0 deletions gemfiles/activerecord_7_2.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "activerecord", "~> 7.2.0"
gem "sqlite3", "~> 1.4"
gem "rspec-rails", "~> 6.0"

gemspec path: "../"
4 changes: 2 additions & 2 deletions gemfiles/activerecord_master.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ git "https://github.com/rails/rails.git" do
gem "activerecord"
end

gem "sqlite3", "~> 1.4"
gem "rspec-rails", "~> 5.0"
gem "sqlite3", "~> 2.0"
gem "rspec-rails", "~> 6.0"

gemspec path: "../"

0 comments on commit fbb1e36

Please sign in to comment.