-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCR-4888: Add update email settings api #3104
Open
JasonLin0991
wants to merge
13
commits into
mcr-4893-parameter-store-flagged
Choose a base branch
from
jl-mcr-4888-add-update-email-settings-api
base: mcr-4893-parameter-store-flagged
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MCR-4888: Add update email settings api #3104
JasonLin0991
wants to merge
13
commits into
mcr-4893-parameter-store-flagged
from
jl-mcr-4888-add-update-email-settings-api
+521
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonLin0991
changed the base branch from
main
to
mcr-4893-adjust-apollo-gql-hanlder-to-use-feature-flag
January 24, 2025 16:10
… into jl-mcr-4888-add-update-email-settings-api
… into jl-mcr-4888-add-update-email-settings-api
… into jl-mcr-4888-add-update-email-settings-api
haworku
changed the base branch from
mcr-4893-adjust-apollo-gql-hanlder-to-use-feature-flag
to
mcr-4893-parameter-store-flagged
January 29, 2025 22:05
haworku
reviewed
Jan 29, 2025
expect(result.success).toBe(false) | ||
}) | ||
|
||
it('should reject malformed email aliases', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JasonLin0991 ⭐on covering the test cases
haworku
changed the base branch from
mcr-4893-parameter-store-flagged
to
mcr-4893-adjust-apollo-gql-hanlder-to-use-feature-flag
January 30, 2025 16:23
haworku
changed the base branch from
mcr-4893-adjust-apollo-gql-hanlder-to-use-feature-flag
to
mcr-4893-parameter-store-flagged
January 30, 2025 16:24
mojotalantikite
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MCR-4888
AC:
z.string().email().optional()
for each item in the string array.Related issues
Screenshots
Test cases covered
settings.test.ts
Tests the Zod custom validator for emailSettingsSchema
'should validate emails with display names'
'should validate plain emails'
'should trim white space of emails'
'should reject empty email settings'
'should reject invalid email format'
'should reject empty email arrays'
'should reject malformed email aliases'
updateEmailSettings.test.ts
resolver tests
'updates email settings'
'errors when on failed email validations'
'errors when user is not an admin'
QA guidance