Skip to content

Commit

Permalink
fix(node version on runner): node16 to node18 (#49)
Browse files Browse the repository at this point in the history
* Added functionality to remove the current user as a watcher on the new ticket

* added code to set priority based on severity

* added axios to support removing watchers from tickets (jira-client does not include)

* clean up

* Added createdAt field to our findings and a filter to only create Jira issues if the finding has existed for longer than 24 hours

* update output to prepare for sending to slack via GitHub action

* Jira needs priority ID as a string in an object

* update dependencies

* Update macpro-security-hub-sync.ts

* Update macpro-security-hub-sync.ts

* updates based on PR feedback

* upgrade from node 16 to 18
  • Loading branch information
JonHolman authored Mar 20, 2023
1 parent fa71b30 commit 4097509
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- run: npm ci
- run: npm run build
- run: npx semantic-release
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- run: npm ci
- run: npm run test
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- run: npm install
- run: npm run coverage
- name: publish test coverage to code climate
Expand Down
4 changes: 2 additions & 2 deletions examples/.github/workflows/security-hub-jira-sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18

# AWS credentials must be provided to get findings from security hub; how you inject credentials can vary.
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1-node16
uses: aws-actions/configure-aws-credentials@v2
with:
role-to-assume: ${{ secrets.AWS_OIDC_ROLE_TO_ASSUME }}
aws-region: us-east-1
Expand Down

0 comments on commit 4097509

Please sign in to comment.