Remove Cypress #834
Remove Cypress #834
Conversation
JonHolman
requested review from
BearHanded,
braxex and
jessabean
as code owners
| @@ -158,8 +152,6 @@ ESLint works in a similar manner for all code linting. | |||
|
|
|||
| On a push to the repository or opening a pull request the [deploy.yml](https://github.com/Enterprise-CMCS/macpro-mdct-mfp/blob/main/.github/workflows/deploy.yml) file runs. This script sets up and does a number of things. For a simple push it's mostly checking code coverage. | |||
|
|
|||
There was a problem hiding this comment.
Nice to have would just be something that explains that playwright exists and is used in this repo. That said, it's beyond the scope of the ticket so take it or leave it.
| @@ -303,15 +303,15 @@ | |||
| ] | |||
| }, | |||
| { | |||
| "username": "cypressadminuser@test.com", | |||
| "username": "e2eadminuser@test.com", | |||
There was a problem hiding this comment.
I guess these get fixed when we deploy again so that the dynamo tables have them in there? Pardon my ignorance.
There was a problem hiding this comment.
Good question. I know on new environments the create users bootstrap function will create the users based on this file, but I'm not sure about when we update an existing environment. I'll have to check after we merge to main. I'm expecting we may need to trigger the bootstrap users function manually.
Thanks @peoplespete . I'm going to wait to review with the team when they return on Thursday. |
There was a problem hiding this comment.
Looks good! Thanks for making these updates.
I think the playwright test step is set to "pass" even if the tests fail, and in the latest run it looks like they failed.
Do we want to ensure those tests are reliable before merging this?
cc: @jessabean
|
Code Climate has analyzed commit 56c5adf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 93.8% (0.0% change). View more on Code Climate. |
Description
Remove Cypress
Related ticket(s)
CMDCT-4217
CMDCT-4218
CMDCT-4221
How to test
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod