CMDCT-4279 - adds correct config for s3 bucket (#865)

Co-authored-by: Jon Holman <[email protected]>

run

@@ -32,9 +32,10 @@ if ! which yarn > /dev/null ; then
 fi
 
 # check serverless is installed globally.
-if ! which serverless > /dev/null ; then
-	echo "installing serverless globally"
-	yarn global add [email protected]
+if ! which serverless > /dev/null || ! serverless --version 2>&1 | grep -q " 4."; then
+    echo "installing serverless v4 globally"
+    yarn global add [email protected]
+    export PATH="$PATH:$(yarn global bin)"
 fi
 
 # have to ensure that yarn install is up to date.

services/app-api/serverless.yml

@@ -23,7 +23,7 @@ custom:
   serverlessPluginTypescript:
     tsConfigFileLocation: "./tsconfig.json"
   stage: ${sls:stage}
-  region: ${aws:region}
+  region: ${self:provider.region}
   wafPlugin:
     name: ${self:service}-${self:custom.stage}-webacl-waf
   wafExcludeRules:

services/uploads/serverless.yml

@@ -226,6 +226,13 @@ resources:
           ServerSideEncryptionConfiguration:
             - ServerSideEncryptionByDefault:
                 SSEAlgorithm: AES256
+        PublicAccessBlockConfiguration:
+          BlockPublicAcls: true
+          BlockPublicPolicy: true
+          IgnorePublicAcls: true
+          RestrictPublicBuckets: true
+        VersioningConfiguration:
+          Status: Enabled
         AccessControl: Private
   Outputs:
     AttachmentsBucketName: # Print out the name of the bucket that is created