Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include text directly in components (removing verbiage files) #100

Merged
merged 18 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions services/ui-src/src/components/accordions/AccordionItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,16 @@ import {
AccordionButton,
AccordionItem as AccordionItemRoot,
AccordionPanel,
CSSObject,
Image,
Text,
} from "@chakra-ui/react";
import plusIcon from "assets/icons/accordion/icon_plus.svg";
import minusIcon from "assets/icons/accordion/icon_minus.svg";

export const AccordionItem = ({ label, children, ...props }: Props) => {
export const AccordionItem = ({ label, children, sx: sxOverride }: Props) => {
benmartin-coforma marked this conversation as resolved.
Show resolved Hide resolved
return (
<AccordionItemRoot sx={sx.root} {...props}>
<AccordionItemRoot sx={sxOverride ?? sx.root}>
{({ isExpanded }) => (
<>
<AccordionButton
Expand All @@ -35,8 +36,8 @@ export const AccordionItem = ({ label, children, ...props }: Props) => {

interface Props {
children?: ReactChild | ReactChild[];
[key: string]: any;
label?: string;
sx?: CSSObject;
}

const sx = {
Expand Down
44 changes: 0 additions & 44 deletions services/ui-src/src/components/accordions/FaqAccordion.test.tsx

This file was deleted.

33 changes: 0 additions & 33 deletions services/ui-src/src/components/accordions/FaqAccordion.tsx

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

5 changes: 3 additions & 2 deletions services/ui-src/src/components/alerts/Alert.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@ const alertIcon = "test-file-stub";
const alertComponent = (
<Alert
title="Test alert!"
description="This is for testing."
link="https://example.com"
icon={alertIcon}
showIcon={true}
/>
>
This is for testing.
</Alert>
);

describe("<Alert />", () => {
Expand Down
Loading
Loading