Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): Dashboard tests #1133

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat(test): Dashboard tests #1133

wants to merge 16 commits into from

Conversation

thetif
Copy link
Collaborator

@thetif thetif commented Feb 6, 2025

🎫 Linked Ticket

OY2-29687

πŸ’¬ Description / Notes

A couple of more tests for Dashboard

πŸ›  Changes

  • minor change to useGetUser to look for username in field username or Username because I think it sometimes comes back from Cognito like that
  • tests for dashboardLoader
  • tests for Pagination

@thetif thetif temporarily deployed to test-dashboard-3 February 6, 2025 17:01 — with GitHub Actions Inactive
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Coverage Report

Status Category Percentage Covered / Total
🟒 Lines 92.36% (🎯 90%)
⬆️ +0.21%
4413 / 4778
🟒 Statements 91.85% (🎯 90%)
⬆️ +0.19%
4806 / 5232
🟒 Functions 86.66% (🎯 85%)
⬆️ +0.13%
1345 / 1552
🟒 Branches 81.05% (🎯 80%)
⬆️ +0.22%
2331 / 2876
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/api/useGetUser.ts 100%
🟰 ±0%
84.61%
⬇️ -7.05%
100%
🟰 ±0%
100%
🟰 ±0%
Generated in workflow #2003 for commit 6ef41bf by the Vitest Coverage Report Action

Copy link
Collaborator

@andieswift andieswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! the it.each is so cool I didn't know about that and also good catch in useGetUser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants